posted on Monday, July 16, 2007 5:10 PM
by
Jonathan Hodgson
Code review primer
There are a number of code-review products on the market, including
Cenqua Crucible and
features inside Jetbrains IntelliJ but it's worth remembering a
few key points as described by MarkLon:
1. Does the code do what it is supposed to do?
2. Does the code cover all cases?
3. Is the code quality good?
4. Does the code do too much?
5. Does the code do too little validation?
6. Does the code expose too much?
7. Are all exceptions handled?
8. When modifying code, has a new path into the internals of the code been created?
9. Comments that make you think the code does something but actually it is different.
Also well worth all developers reading
Refactoring and
Code Complete every couple of years (or even months).